Remove some hh_fixmes - Githubissues

hhvm / hacktest

A unit testing framework for Hack

MIT License

29 stars 12 forks source link

Closed lexidor closed 4 years ago

jjergus commented 4 years ago

Oh, looks like now it fails on HHVM 4.8... so I guess that FIXME was needed after all :(

Can you either

verify this is only a typechecker issue (doesn't fail at runtime) and add a FIXME, or
if it's also a runtime issue, revert that part, or
figure out what HHVM version is needed to avoid the issue and update composer.json and .travis.yml accordingly?

lexidor commented 4 years ago

Whoops, this is indeed an HHI issue. HHVM 3.30 already had the function at runtime, but the hhi was written way later.

hphpd> =varray(vec[1]);
=varray(vec[1]);
Array
(
    [0] => 1
)

hphpd> =HHVM_VERSION
=HHVM_VERSION
"3.30.12"
hphpd>

It's my bad that I did not bother reading the travis output myself. Sorry for the wasted time.