hhvm / hhvm-docker

Dockerfiles for HHVM
MIT License
55 stars 11 forks source link

fix build-and-tag.sh for 3.30 #15

Closed jjergus closed 5 years ago

jjergus commented 5 years ago

I think this is why the "publish" step always fails for 3.30.

fredemmott commented 5 years ago

This might also need cherry-picking into the 3.30 branch

jjergus commented 5 years ago

The 3.30 branch doesn't pass the HHVM_REPO_DISTRO argument to Docker. I'm not sure why that is, but as far as I can tell this script is always run from master so it doesn't matter.