hhvm / homebrew-hhvm

Official Mac OS X Homebrew formula for HHVM
MIT License
82 stars 22 forks source link

build-release.sh fixes #136

Closed jjergus closed 4 years ago

jjergus commented 4 years ago

As far as I can tell, the other commits we make before the build (adding formula, bumping version) are fine, since if multiple concurrent builds make those commits, they'll all be identical.

I don't have anything to test this on (I only noticed the issue after all the builds for the current revision were already running) so please review carefully. I'll check that the next nightly build succeeds, but most of this won't be properly tested until the next time we need to publish a revision.

jjergus commented 4 years ago

I suppose it's safest to do this both at the beginning (like before) and after each rebase (to fix the merge conflict issue), so I changed it to do that.