search

hhvm / homebrew-hhvm

Official Mac OS X Homebrew formula for HHVM
MIT License
81 stars 22 forks source link

Add aardvark_shell_utils as a build dependency, providing the CLI tool `realpath` #145

Closed Atry closed 2 years ago

Atry commented 2 years ago

The mac build fails constantly since https://github.com/facebook/hhvm/commit/8c8f1bad16e5b485fd94311df7031327bfcfb0b7, which uses the CLI tool realpath, which was not installed. This PR installs the required tool.

Atry commented 2 years ago

Triggered bin/build-on-aws 2022.02.02 BuildAndPublishMacOS to test this PR

fredemmott commented 2 years ago

These can also be retried by clicking on a failed run in Azure, then picking 'rerun failed jobs'; this will pick up the new version of this repo.

As there isn't (wasn't) an API for triggering jobs, they're keyed to commits in the build-triggers branch, not master

fredemmott commented 2 years ago

No significant difference in retry approach, just a little quicker and fewer moving parts.