IO/OS: Rename private namespaces for consistency with new builtins

hhvm / hsl-experimental

Experimental features for the Hack Standard Library

MIT License

23 stars 10 forks source link

IO/OS: Rename private namespaces for consistency with new builtins #115

Closed fredemmott closed 4 years ago

fredemmott commented 4 years ago

Old: HH\Lib\Experimental\Foo\_Private New: HH\Lib\_Private\_Foo

Reduces need for as, and if used consistently, increases readability - for example, IO can reasonable need to refer to IO and OS, and their private versions; if done consistently, this is IO\foo, _IO\foo, OS\foo and _OS\foo, rather than pulling in multiple namespaces named '_Private'

facebook-github-bot commented 4 years ago

@fredemmott merged this pull request in hhvm/hsl-experimental@241964c74e64e88597a6cd06e3d69080aa23aaf0.