[easy] make HSL IO write API consistent with read API

hhvm / hsl-experimental

Experimental features for the Hack Standard Library

MIT License

23 stars 10 forks source link

Closed fredemmott closed 4 years ago

fredemmott commented 4 years ago

rawFooBlocking() -> foo(), matching the OS\ function
float $timeout_sec() = 0 -> ?int $timeout_ns = null
only do one write(); don't loop until the very end
- this is less clearly the correct thing to do compared to read(), however given it's needed for read(), I think it's best for consistency
clean up some $chunk = foo(); return $chunk; I saw while looking through the read implementations

facebook-github-bot commented 4 years ago

@fredemmott merged this pull request in hhvm/hsl-experimental@872815fa37d58e1fe871c7b9f2d7ce9f2ef03b64.