Remove IO\server_output(), IO\server_error() - Githubissues

hhvm / hsl-experimental

Experimental features for the Hack Standard Library

MIT License

23 stars 10 forks source link

Remove IO\server_output(), IO\server_error() #126

Closed fredemmott closed 4 years ago

fredemmott commented 4 years ago

I believe these are dangerous, and not actually useful; error logging builtins should be used instead.

Dangerous as:

it breaks fastcgi over STDIO
it breaks anything else consuming HHVM output, perhaps e.g. log parsers
if error logs are redirected with HHVM config option rather FD redirection, anything written to server_error() will not be in the error log
exposing non-read-only per-process things to requests just seems like a bad idea. Makes more sense in PHP where there is a process-per-request (fastcgi is handled by a separate master process).

facebook-github-bot commented 4 years ago

@fredemmott merged this pull request in hhvm/hsl-experimental@88507ba41b17579cd548c712dade22a53d349f64.