Add EINVAL assertion helper, consistently use it in HSL IO

hhvm / hsl-experimental

Experimental features for the Hack Standard Library

MIT License

23 stars 10 forks source link

Add EINVAL assertion helper, consistently use it in HSL IO #145

Closed fredemmott closed 4 years ago

fredemmott commented 4 years ago

Add _OS\arg_assert($condition, $message_fmt, ...)
Use it to replace:
- if (!$argument_condition) { throw () } when condition is not type-refining
- invariant()s on arguments

In practical terms, HSL IO will now consistently raise EINVAL for bad arguments, instead of a mix of EINVAL, InvariantException, and InvalidArgumentException.

fixes #143

facebook-github-bot commented 4 years ago

@fredemmott merged this pull request in hhvm/hsl-experimental@7d151aa60f4d78441ea8b4d4e801d811cb070755.