s/public function write/protected function writeImpl/

hhvm / hsl-experimental

Experimental features for the Hack Standard Library

MIT License

23 stars 10 forks source link

Closed fredemmott closed 3 years ago

fredemmott commented 3 years ago

rename: make it clear that it's only an implementation detail; users should only use the async functions writeAllAsync or writeAllowPartialSuccessAsync
make it protected: given it's the only non-awaitable writer, it's still too tempting, and unneccessary

I'm not aware of any edge cases, but if they exist, getFileDescriptor() can be used in combination with OS\write(). This

Will follow up with a similar change to read()

refs #173

facebook-github-bot commented 3 years ago

@fredemmott merged this pull request in hhvm/hsl-experimental@20cb53a2466ef4aa29f0a7767784647ad27173d5.