search

hhvm / hsl-experimental

Experimental features for the Hack Standard Library
MIT License
23 stars 10 forks source link

HSL DateTime: codegen DateTime\Zone enum #182

Closed jjergus closed 3 years ago

jjergus commented 3 years ago

Includes the codegen logic (bin/codegen-timezones.php) and the generated file. The docblock explains the rationale for what is and isn't included in the enum.

I'm not sure if we want to commit the codegen logic, but it probably makes sense to keep it somewhere so that the enum can be regenerated e.g. when HHVM is built in the future with a newer version of tzdata.

jjergus commented 3 years ago

I think it's better to start more restrictive, then we can relax the restrictions later if anyone needs it (it's much harder to go the other way), so for now I would rather avoid supporting arbitrary strings as well as any confusing/ambiguous/deprecated aliases.