search

hhvm / packaging

The sources for how we have built the HHVM packages.
MIT License
64 stars 63 forks source link

Docker build doesn't include sodium #169

Closed simonwelsh closed 5 years ago

simonwelsh commented 5 years ago 
Yogurt:~/projects/cbrx-drupal simon$ docker run -it hhvm/hhvm:latest
root@ef2068c37fa6:/# hhvm --version
HipHop VM 3.30.2 (rel)
Compiler: 1547490432_038329274
Repo schema: 7b58ebf11f7e63a9dacf86dc53a81101a2d8204a
root@ef2068c37fa6:/# hhvm -a
Welcome to HipHop Debugger!
Type "help" or "?" for a complete list of commands.

Note: no server specified, debugging local scripts only.
If you want to connect to a server, launch with "-h" or use:
  [m]achine [c]onnect <servername>

hphpd> = function_exists('sodium_add')
= function_exists('sodium_add')
false

The home-brew version returns true, so likely related specifically to the Docker build process.

fredemmott commented 5 years ago

This really belongs in hhvm/hhvm-docker :)

so likely related specifically to the Docker build process.

The Docker images use the Ubuntu packages; they're currently built on Ubuntu 16.04, which doesn't have a new enough libsodium. Fixing this by bumping up to 18.04