hhvm / packaging

The sources for how we have built the HHVM packages.
MIT License
64 stars 63 forks source link

Apply patches/ before creating source tarball, and remove #200

Open fredemmott opened 5 years ago

fredemmott commented 5 years ago

Not doing this immediately to minimize changes while fixing debian-8-jessie

jjergus commented 4 years ago

should we do this now?

fredemmott commented 4 years ago

this would still be good, but low-impact...

... on the other hand, if we're patching the source tarballs, it could be a good way to inject the HSL and somewhat higher impact :)

Problem there is testing changes to the HSL itself; HHVM has mechanisms for this (runtime-optional-extensions), but i think we'd need something like __PHPStdLib, but for the HSL, to make the HHIs work