search

hhvm / packaging

The sources for how we have built the HHVM packages.
MIT License
64 stars 63 forks source link

one state machine to rule them all #217

Closed jjergus closed 4 years ago

jjergus commented 4 years ago

See README.md for lots of details.

There's a lot of code here and most of it is probably not particularly interesting to review, so feel free to just look at whatever you find interesting. It's reasonably well tested so you shouldn't need to review it carefully for bugs etc.

I gave things silly joke names so I wouldn't confuse new stuff with old stuff while we have both in the repository, but if this works well and we decide to get rid of the old stuff, we can then rename things to have more obvious names (build-on-aws instead of qaz etc.)

jjergus commented 4 years ago

Oops I don't know how you found this before I even published the PR, but see updated summary above ^

I died a little inside.

Wait until you see the Python ternary expressions (with condition in the middle, of course!) and "comprehensions", I had a lot of fun with those.