Bad paths (typo of PGKROOT/PKGROOT, lib/lib) in debs

hhvm / packaging

The sources for how we have built the HHVM packages.

MIT License

64 stars 63 forks source link

Bad paths (typo of PGKROOT/PKGROOT, lib/lib) in debs #249

Closed fredemmott closed 3 years ago

fredemmott commented 3 years ago

https://github.com/facebook/hhvm/issues/8769

cc @IngwiePhoenix

fredemmott commented 3 years ago

@IngwiePhoenix That should have the PKGROOT issue fixed in the next round of packages; your paste also included lib/lib, which is more subtle, so I want to test more thoroughly before merging

IngwiePhoenix commented 3 years ago

Huh, you're right. I guess I must've overlooked that. Do you have a guess as to when I can expect the fixed debs to show up on the repositories?

fredemmott commented 3 years ago

It'll start with tomorrow's nightly builds; if those are good, at least 4.87, but we should backport these two fixes to past releases - best case would be wednesday

fredemmott commented 3 years ago

Fixed in the nightlies; FYI these are only in the '-dev' packages, which are:

only required if plannign to work on a dynamically loadable HHVM extension
not well tested, and likely broken

You don't need them to run/develop code written in Hack