search

hhvm / packaging

The sources for how we have built the HHVM packages.
MIT License
64 stars 63 forks source link

retry shutdown in worker.sh #254

Closed jjergus closed 3 years ago

jjergus commented 3 years ago

For some reason the AWS EC2 instance sometimes doesn't shut down and just hangs there forever, even though the logs clearly show that it reached the shutdown command and ran it (I just had to manually terminate 6 instances that were created at different points over the last few weeks, it seems completely random).

I don't know what causes it, but maybe this simple hack will help?

facebook-github-bot commented 3 years ago

Hi @jjergus!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!