search

hhvm / packaging

The sources for how we have built the HHVM packages.
MIT License
65 stars 65 forks source link

Use docker cli instead of Docker Hub v1 API #318

Open Atry opened 1 year ago

Atry commented 1 year ago

Docker Hub v1 API has been removed. See https://www.docker.com/blog/docker-hub-v1-api-deprecation/

Test Plan:

$ python3 test.py Test.test_should_run
.
----------------------------------------------------------------------
Ran 1 test in 10.634s

OK
Atry commented 1 year ago

This PR does not work because the Lambda runtime on AWS does not include docker cli

facebook-github-bot commented 1 year ago

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!