hhvm / user-documentation

Documentation for those that use HHVM and write Hack code.
http://docs.hhvm.com/
Other
129 stars 159 forks source link

Fix mistake in documentation, Getting Started: Starting a Real Project, Adding Functions or Classes #1352

Closed tnev closed 1 year ago

tnev commented 1 year ago

https://github.com/hhvm/user-documentation/issues/1351

Where is the problem?

Documentation, Getting Started: Starting a Real Project, Adding Functions or Classes section, code example

What is the problem?

The code example is

use namespace HH\Lib\Vec;

function square_vec(vec<num> $numbers): vec<num> {
  return Vec\map($numbers, $number ==> $number * $number);
}

It then notes "If you then run hh_client, it will tell you of a mistake... To fix this, change the return type of the function from vec to vec."

However the return type is already num in the example.

facebook-github-bot commented 1 year ago

Hi @tnev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Wilfred commented 1 year ago

Thanks, D47734583.