hi-dhl / PokemonGo

神奇宝贝 (PokemonGo) 基于 Jetpack + MVVM + Repository 设计模式 + Data Mapper + Kotlin Flow 的实战项目,如果这个仓库对你有帮助,请仓库右上角帮我 star 一下,非常感谢。
1.59k stars 247 forks source link

[剽竊] Copied project #9

Closed rurimo closed 3 years ago

rurimo commented 3 years ago

This project seems almost copied code from Pokedex but there is no marked?

And I just wonder why did you remove and change every of his libraries and license..? Furthermore, Your library JDataBinding seems plagiarized almost codes. I didn't look into details of codes but JProgressView also similar.

cc. @skydoves

hi-dhl commented 3 years ago

Thanks u , I'm just using the same API with Pokedex, but The architectural and techniques of the projects are different, I've added the declaration

image

about JDataBinding , When I first created and push the project, I've added the declaration

rurimo commented 3 years ago

Thanks for your explanation. But it doesn't matter changing small points of the architecture and technique. (Actually its not a big deal) I mean from the start, everyone can find almost 99% copy-pasted codes in the project and that means referenced already.. So that mostly could be seen as plagiarized even if small pieces of code. And I can see related issue #1

DataBindingActivity

https://github.com/hi-dhl/JDataBinding/blob/master/jdatabinding/src/main/java/com/hi/dhl/jdatabinding/DataBindingActivity.kt https://github.com/skydoves/DisneyMotions/blob/master/app/src/main/java/com/skydoves/disneymotions/base/DatabindingActivity.kt

DataBindingFragment

https://github.com/hi-dhl/JDataBinding/blob/master/jdatabinding/src/main/java/com/hi/dhl/jdatabinding/DataBindingFragment.kt https://github.com/skydoves/DisneyMotions/blob/master/app/src/main/java/com/skydoves/disneymotions/base/DatabindingFragment.kt

di

https://github.com/hi-dhl/PokemonGo/tree/master/app/src/main/java/com/hi/dhl/pokemon/di https://github.com/skydoves/Pokedex/tree/main/app/src/main/java/com/skydoves/pokedex/di

PokemonInfo

https://github.com/hi-dhl/PokemonGo/blob/master/app/src/main/java/com/hi/dhl/pokemon/model/PokemonInfoModel.kt https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt

Anyway, hope you understand the open source license as soon as fast. Thank u :)

hi-dhl commented 3 years ago

Thank you for your patience, I will delete license and I will pay attention to that in the future, Thank u again.