search

hi-ogawa / Stockfish

stockfish-nnue.wasm
https://stockfish-nnue-wasm.vercel.app
GNU General Public License v3.0
97 stars 11 forks source link

[WIP] Update to master as of 2021-07-14 #7

Closed Sopel97 closed 3 years ago

Sopel97 commented 3 years ago

An attempt to port to the newer Stockfish version. I have no experience with emscripten so untested.

PS. I know that the nets are too big for practical use, I'm working on a remedy for this with @niklasf, but first need the wasm port to be updated.

hi-ogawa commented 3 years ago

Thanks for the PR. Also a bit late but congrats for your new net architecture! I've wanted to check it out, but haven't follow the code yet. Maybe I'll do rebasing to upstream's master myself, so I cannot gurantee merging your PR, but thanks anyways for drawing attention to this.

hi-ogawa commented 3 years ago

Hi Sopel, I finished merging the upstream from two days ago (specifically this one https://github.com/official-stockfish/Stockfish/commit/237ed1ef8fddea77779e7fdcde8e4195d92f123b) and now the default branch of my repository is changed to emscripten-237ed1ef-2.0.26. Essentially all the change is squashed and rebased into one commit https://github.com/hi-ogawa/Stockfish/commit/729b62d29d558e850ec22cee9fd03dffb86fe244 and it's working as far as I (and my tests) can tell. If you want, you can check my commit (change in .h and .cpp is not so much) and feel free to let me know if you notice anything. I think this PR won't be useful now, so if you don't mind, I'll close this soon.

EDIT: By the way, while merging to upstream myself, I picked up some ideas from your PR (especially the one with strided affine), so thanks for that!