search

hi-ogawa / test-vite-sass

0 stars 0 forks source link

`css.preprocessorMaxWorkers = true` #1

Open sapphi-red opened 1 month ago

sapphi-red commented 1 month ago

Making an issue here instead as I feel it's a bit off-topic from the PR (https://github.com/vitejs/vite/pull/17728).

I saw this comment here. https://github.com/hi-ogawa/test-vite-sass/blob/29411c86b39270c7ee2691d443dccb219630a173/vuetify/vite.config.ts#L9-L12 Just in case, did you put css.preprocessorMaxWorkers = true? Otherwise, adding that won't change anything.

Example: https://github.com/vitejs/vite/blob/66bdb1d7b41e46b5361606ff3811bdad6f625bcc/playground/css/vite.config.js#L85

hi-ogawa commented 1 month ago

Good point. I think I've toggled it a few times, but probably not in this example. I updated README.md to include the build time with and without preprocessorMaxWorkers. The changes looks like this:

sass improved as expected, but sass-embedded might be suffering overhead of each dart process.