search

hi-ogawa / ytsub-v3

Anki-like language learning app built with Remix
4 stars 0 forks source link

refactor: avoid e2e code to depend on application code #545

Open hi-ogawa opened 8 months ago

hi-ogawa commented 8 months ago

https://github.com/hi-ogawa/ytsub-v3/blob/e0fa9d7f3ff47d458e4ea77693213e640565936d/app/e2e/helper.ts#L10-L10

The reason is that, since playwright runs its own typescript transpilation, it would block using certain vite specific features in application code (though this already happens with "tsx" used for local cli...).

hi-ogawa commented 8 months ago

Probably, what we have to do is to ensure Vite/Remix specific features are only used within app/routes files. Other "utilities" should be able to run at least on Vitest and Tsx anyways.

But, I still feels it's wrong for playwright test code to use much of internal details utilities to check e2e features...