[Feature]: album art support - folder.jpg

hiaaryan / wora

🎧 A beautiful player for audiophiles.

MIT License

401 stars 16 forks source link

[Feature]: album art support - folder.jpg #7

Closed Not-Sure-Whats-Going-On closed 5 months ago

Not-Sure-Whats-Going-On commented 5 months ago

I'm very impressed with the look and sound of Wora so far - this could replace Tauon as my default player! I have a couple of issues.

All albums where the album art that is embedded in the file display fine. My library has each album in its own directory. Many (many!) of the albums have the album art not embedded but as a file called folder.jpg in the directory. These albums show up in Wora with just the default placeholder as the album art. Can you please give the option to display album art from external files such as folder.jpg?
Also, the search function doesn't find either Artist or Albumartist from the embedded meta tags.

Thanks!

hiaaryan commented 5 months ago

This is a valid issue. I have several albums which have an image in the folder but are not embedded in the song metadata itself.

Currently, Wora is just taking the album art from the song itself and assigns it to the album.

There is a better way to do this, which I have had in mind for some time. We can select any available image available in the album folder file => /\.(jpg|jpeg|png|gif)$/.test(file) & fallback to any image available in the song metadata. Also add an option in albums page to edit the cover image.

The search function not indexing the artists is a known issue and this will be fixed when artist page is added in a future update soon 🎉

Not-Sure-Whats-Going-On commented 5 months ago

Brilliant, thanks Aaryan! Look forward to the new release.

hiaaryan commented 5 months ago

No worries, just keeping this open till the features are implemented.

hiaaryan commented 5 months ago

This issue has been fixed in release v0.3.3. Since artists page is planned in milestone, I am closing this issue 😄