[Intro to iOS] Week 2

[hiawc]

Here is my week 2 submission. Thank you very much. /cc @coderschoolreview

[minhchau273]

Hi Nhat,

Sorry for the late review.

It looks like you still need to complete a required user story for your submission to be complete.

• [ ] Search bar should be in the navigation bar. Note that you just added the search bar and didn't implement search feature. You have to send request to the API to get the results when searching.

Your assignment needs to be updated within 24hrs in order for you to receive credit for this assignment.

Thanks, Chau

[hiawc]

Oops, I just updated the searchBar search function. Next time I will try to read the requirements more carefully. Thanks for the reminder.

[minhchau273]

:+1: Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

• Functionality: Good
• Code Style: Good
• Visual Design: Good
• Usability: Good

Overall: Good

Detailed Notes

• Nice work specifying the Auto Layout constraints.
• Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
• Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
• You miss the trailing space to super view constraint so that the addressLabel is truncated in this cell.
• The autolayout may not work well in the filters screen.
• That would be nice is if you handled the "no results" case gracefully, as well as didn't show empty gray lines when there is only 1 result.
• It'd be better if you show the selected option when collapsing the distance and sort by fields in the filters screen.