make_exp/1 in some test cases creates expiration time that will never expire in a test scenario

[tatsuya6502]

The following test modules have make_exp/1 function:

• gdss-admin
  • test/eunit/brick_replace_rename_tests.erl
  • test/eqc/squorum_eqc_tests.erl
  • test/eqc/simple_eqc_tests.erl
• gdss-ubf-proto
  • test/eunit/ubf_gdss_plugin_tests.erl

It first looked like make_exp/1 returns a key-value expiration time expiring in given milli-seconds. But I think it's creating expiration time that is 10^6 times bigger than the intended value.

-spec make_exp(non_neg_integer()) -> exp_time().
make_exp(StepMillis) ->
    {MSec, Sec, USec} = now(),
    NowX = (MSec * 1000000 * 1000000) + (Sec * 1000000) + USec,
    (NowX * 1000) + StepMillis.

NowX is in micro-seconds and a key-value expiration time is in milli-seconds. So (NowX * 1000) should read (NowX div 1000) to achieve micro to milli-seconds conversion.

Also, those eqc test models do not have conditions to handle expired key-values. They need to be added before make_exp/1 is corrected.