Update the external libraries (ubf, ubf-thrift) to the latest version

tatsuya6502 commented 11 years ago

Update the external libraries related to gdss-ubf-proto to the latest version.

ubf
ubf-thrift

We might want to wait until the changes for Erlang/OTP R16 to be merged to their master branches.

tatsuya6502 commented 11 years ago

Changed the subject from "...(March 2013)" to "...(April 2013)".

tatsuya6502 commented 11 years ago

Need to test the following functionality added to Hibari v0.3.0:

Server side timestamp and rename: https://github.com/hibari/gdss-brick/issues/10
attrib and exp_time directive flags to rename/6: https://github.com/hibari/gdss-brick/issues/13
attrib and exp_time directive flags to replace/6 and set/6: https://github.com/hibari/gdss-brick/issues/14

tatsuya6502 commented 9 years ago

Need to test the following functionality added to Hibari v0.3.0 (-> v0.1.11):

Server side timestamp and rename: https://github.com/hibari/gdss-brick/issues/10

attrib and exp_time directive flags to rename/6: https://github.com/hibari/gdss-brick/issues/13

attrib and exp_time directive flags to replace/6 and set/6: https://github.com/hibari/gdss-brick/issues/14

The current eunit cases in ubf_gdss_plugin_tests contains changes for server side timestamp. So I need to add test cases for server side rename and these directive flags.

The enuit cases are currently not building due to type spec errors in auto-generated hrl files.

% gmake compile-for-eunit
...
==> gdss_ubf_proto (eunit)
Compiled src/gdss_ubf_proto.erl
Compiled src/gdss_ubf_proto_sup.erl
Compiled src/ubf_gdss_plugin.erl
Compiled src/ubf_gdss_stub_plugin.erl
Compiled test/eunit/brick_eunit_utils.erl
Compiling /usr/home/tatsuya/workhub/dev/hibari-dev/hibari/lib/gdss_ubf_proto/test/eunit/ubf_gdss_eunit_utils.erl failed:
/usr/home/tatsuya/workhub/dev/hibari-dev/hibari/lib/gdss_ubf_proto/ebin/ubf_gdss_plugin.hrl:218: type undefined() undefined
/usr/home/tatsuya/workhub/dev/hibari-dev/hibari/lib/gdss_ubf_proto/ebin/ubf_gdss_plugin.hrl:335: type atom(_,_) undefined
/usr/home/tatsuya/workhub/dev/hibari-dev/hibari/lib/gdss_ubf_proto/ebin/ubf_gdss_plugin.hrl:191: type set/0 is deprecated and will be removed in OTP 18.0; use use sets:set/0 or preferably sets:set/1
ERROR: eunit failed while processing /usr/home/tatsuya/workhub/dev/hibari-dev/hibari/lib/gdss_ubf_proto: rebar_abort
Makefile:143: recipe for target 'compile-for-eunit' failed
gmake: *** [compile-for-eunit] Error 1

tatsuya6502 commented 9 years ago

Fixed the type spec errors in auto-generated hrl files.

See https://github.com/ubf/ubf/issues/13 for more details.

tatsuya6502 commented 9 years ago

Need to test the following functionality added to Hibari v0.3.0 (-> v0.1.11):

Server side timestamp and rename: https://github.com/hibari/gdss-brick/issues/10

attrib and exp_time directive flags to rename/6: https://github.com/hibari/gdss-brick/issues/13

attrib and exp_time directive flags to replace/6 and set/6: https://github.com/hibari/gdss-brick/issues/14

Added simple eunit cases to test all above in UBF protocol: https://github.com/hibari/gdss-ubf-proto/commit/f54ff42f0dc45cc936a7d413df266afaa1f6e00c

Test results:

Erlang/OTP 17 [erts-6.3] [source] [64-bit] [smp:8:8] [async-threads:64] [hipe] [kernel-poll:true]

Eshell V6.3  (abort with ^G)
(hibariclient@127.0.0.1)1> ubf_gdss_plugin_tests:test().
...
  All 20 tests passed.
ok
(hibariclient@127.0.0.1)2>

There is no eunit cases for Thrift as it's an incomplete, prototype implementation. I'll leave it for now.

Closing this issue.

hibari / gdss-ubf-proto

Update the external libraries (ubf, ubf-thrift) to the latest version #7