search

hibbitts-design / grav-skeleton-open-publishing-space

Leverage a fast version-controlled workflow using the editor of your choice in the creation, sharing and collaborative editing of Markdown-based Grav site content. Includes Admin Panel and Git Sync.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
27 stars 15 forks source link

Workflow wasn't generating admin versions. #14

Closed bnnk closed 3 years ago

bnnk commented 3 years ago

Hi, I am BK Shrinandhan. When I was trying to download your theme, I saw that the workflow didn't have a skeleton+Admin nor on the Skeletons page. So I manually re-ran and I have tagged it as v1.6.9.

paulhibbitts commented 3 years ago

Hi @bnnk , I am not sure what you mean as I just checked and the Admin is in the skeleton download - do you mean the theme or skeleton?

paulhibbitts commented 3 years ago

Thanks for the PR, if if I recall I do not use this option as I include the Admin Panel in the default build, and do not create a second build with the Admin. It's been a while I set this up though, so I will keep an eye out for this issue next release. I just checked the most recent Skeleton release on GetGrav.org and it does have the Admin Panel.

FYI, the approach I took to include the Admin Panel in the default ZIP file build was to use the .dependencies file route: https://github.com/hibbitts-design/grav-skeleton-open-publishing-space/blob/master/.dependencies https://getgrav.org/blog/skeletons-build-automation

bnnk commented 3 years ago

@paulhibbitts I see the pull request closed. Is it that we don't want to take the changes and it stays the same way ?. Just want to know for my clarification..

paulhibbitts commented 3 years ago

Hi @bnnk, that is correct as with my default build the Admin Panel is included already. Download your test build https://github.com/bnnk/grav-skeleton-open-publishing-space/releases/download/v1.6.9/grav-skeleton-open-publishing-space.zip and you will see this once the ZIP is expanded (look in the Plugins folder).