search

hibbitts-design / grav-theme-quark-open-publishing

A customized version of the Quark theme with Git Sync and 'chromeless' mode support.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
21 stars 13 forks source link

Archives and Popular Tags not shown on item-pages #12

Closed McGlear closed 5 years ago

McGlear commented 5 years ago

While "Archive" entries and "Popular Tags" get rendered on the listings page (like the home of this theme's demo), they do not appear on the actual blog item pages. Only the respective headers are put into the sidebar.

noarchives

The base Quark theme doesn't have this problem (compare the single item page behaviour in the blog-skeleton demo) and outputs the tags and archive entries as expected.

paulhibbitts commented 5 years ago

Hi @McGlear , thanks for reporting this issue.

Re: Archives display, this was due to mistakenly including the needed setting to support multiple blogs in the Open Publishing skeleton. Here is the YAML for the Archives plugin to get that working:

enabled: true
built_in_css: true
date_display_format: 'F Y'
show_count: true
limit: 12
order:
  by: date
  dir: desc
filter_combinator: and
filters:
    category: blog
taxonomy_names:
  month: archives_month
  year: archives_year

I've identified the issue with Popular Tags and will be releasing a theme update shortly to address that issue.

Please let me know how things go once that update is released. Paul

UPDATE: New version of the Quark Open Publishing theme with bug fix is now available

McGlear commented 5 years ago

Thank you, @paulhibbitts

It's an almost perfect fix: Popular Tags work as expected, Archive gets rendered everywhere - and from the listings-page of my "Blog 2", the archive actually links to wwwroot/blog2/archives_month:jun_2017 as was discussed in issue #11.

When viewing an actual item from blog2, however (let's say we copied over the skeleton items from 01.blog into 11.blog2, so we can view wwwroot/blog2/hero-classes), the archive links appear, but are pointing back at wwwroot/archives_month:jun_2017 instead of wwwroot/blog2/archives_month:jun_2017.

paulhibbitts commented 5 years ago

Hi @McGlear , addressing that issue was the goal of the tweak to the Archives config but alas it causes other issues as you discovered at the blog item level (vs. the blog list level). Right now the Archives plugin supports a single blog per site... others have tried to address this issue too but I am not aware of a fully working solution myself yet.

As the original bug of this issue has now been addressed I will close this but please feel free to re-open or connect in the Discord room if you can solve the issue in another way.