search

hibbitts-design / grav-theme-quark-open-publishing

A customized version of the Quark theme with Git Sync and 'chromeless' mode support.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
21 stars 13 forks source link

Add Japanese translation to languages.yaml #24

Closed OrthoCube closed 5 years ago

OrthoCube commented 5 years ago

I want Quark Open Publishing to support Japanese so I added a Japanese translation to languages.yaml and contributed. This is the first time I contributed to an open-source project! I hope I'm doing this right! If I'm not, I'm really sorry.

paulhibbitts commented 5 years ago

Hi @OrthoCube , thanks so much for this Japanese translation PR! Everything looks good, and I plan to release a theme update with this addition very soon.

BTW, if this update looks good you might also want to consider making a PR on the parent theme of Quark Open Publishing so even more users can benefit from your translation work: https://github.com/getgrav/grav-theme-quark/blob/develop/languages.yaml

OrthoCube commented 5 years ago

Thanks! I'm glad that it was all fine!

Thanks for reminding me about the parent theme--I would have forgotten if you didn't mention. I definitely will!

paulhibbitts commented 5 years ago

Thanks very much, and congrats on your open source contribution!