Closed B1gG closed 4 years ago
Thanks for the PR @B1gG - however, it looks like the Breadcrumb plugin is being checked for and not the ReadingTime plugin?
I also think if we proceed with the support of ReadingTime we would also need to address non-hero pages, I've put a sample below:
Yes, you are absolutely right, anbd there is where I will need your help, I am not a PHP guy :) In the fork I have I included the scripts and the check, probably you can check it to see if that could work.
No problem, I appreciate your contributions! You would only need Twig for the check, it will look like this:
{% if config.plugins.readingtime.enabled %}
I can make this change on my end.
Re: dependency, I am currently trying to further minimize them so let's not add that for now. With your script changes if a user installs ReadingTime they will be able to use it right away and not do any script changes.
I will accept the changes now, do a bit of fine-tuning, and give you a status update.
Cheers, Paul
Hi @B1gG , I've added ReadingTime to the blog list items (shown below) as well as your other changes and have a working prototype going at https://blog.hibbittsdesign.org/
Please let me know what you think and then I can release the theme with this new feature (and will credit you in the ChangeLog🙂).
Theme update now released with this feature, thanks again for the PRs!
great stuff !!!, thanks. I am also working to update the breadcrumbs plugin to add support for schema as per google advisory
this will be used to include the reading time on a blog post