hibbitts-design / grav-theme-quark-open-publishing

A customized version of the Quark theme with Git Sync and 'chromeless' mode support.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
21 stars 13 forks source link

creating the file readingtime.html.twig #30

Closed B1gG closed 4 years ago

B1gG commented 4 years ago

this will be used to include the reading time on a blog post

paulhibbitts commented 4 years ago

Thanks for the PR @B1gG - however, it looks like the Breadcrumb plugin is being checked for and not the ReadingTime plugin?

I also think if we proceed with the support of ReadingTime we would also need to address non-hero pages, I've put a sample below:

2020-01-14_15-10-18
B1gG commented 4 years ago

Yes, you are absolutely right, anbd there is where I will need your help, I am not a PHP guy :) In the fork I have I included the scripts and the check, probably you can check it to see if that could work.

paulhibbitts commented 4 years ago

No problem, I appreciate your contributions! You would only need Twig for the check, it will look like this:

{% if config.plugins.readingtime.enabled %}

I can make this change on my end.

Re: dependency, I am currently trying to further minimize them so let's not add that for now. With your script changes if a user installs ReadingTime they will be able to use it right away and not do any script changes.

I will accept the changes now, do a bit of fine-tuning, and give you a status update.

Cheers, Paul

paulhibbitts commented 4 years ago

Hi @B1gG , I've added ReadingTime to the blog list items (shown below) as well as your other changes and have a working prototype going at https://blog.hibbittsdesign.org/

2020-01-15_07-55-11

Please let me know what you think and then I can release the theme with this new feature (and will credit you in the ChangeLog🙂).

paulhibbitts commented 4 years ago

Theme update now released with this feature, thanks again for the PRs!

B1gG commented 4 years ago

great stuff !!!, thanks. I am also working to update the breadcrumbs plugin to add support for schema as per google advisory