search

hibbitts-design / grav-theme-quark-open-publishing

A customized version of the Quark theme with Git Sync and 'chromeless' mode support.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
21 stars 13 forks source link

svg logo #4

Closed zaszlo closed 6 years ago

zaszlo commented 6 years ago

The logo can be changed by putting a file in the images/logo directory and calling it from the theme's yaml file, like:

custom_logo:
  -
    name: xyz.svg

The problem is that this renders the svg as an image, not as on the demo page with plain svg, so having a black&white svg like in the demo wont be switched when having light or dark background... I think the solution would be to render svg's in the way it is in the demo. Tried to override this by naming my logo to grav-logo.svg and putting it to my active theme's iamges folder but keeps reading the default grav-logo.svg from the parent theme. Replacing the grav-logo.svg from quark theme solves the problem... until the next update.

paulhibbitts commented 6 years ago

Hi @zaszlo , I don't think my theme changes anything related to Logo handling, which was just added to Quark recently. Please feel free to contact me in the Grav Slack room if you have further questions too https://getgrav.org/slack

zaszlo commented 6 years ago

Thanks @paulhibbitts for pointing to that chat room! I'll move the issue to the quark theme.