search

hibbitts-design / grav-theme-quark-open-publishing

A customized version of the Quark theme with Git Sync and 'chromeless' mode support.
http://demo.hibbittsdesign.org/grav-open-publishing-quark/
MIT License
21 stars 13 forks source link

cleanup & formatting #9

Closed RobLui closed 5 years ago

RobLui commented 5 years ago

Formatting & cleanup

-> Just an improvement on readability for future maintainers/users of this repo -> Let me know if you'd like anything changed in the PR if it's not what you've got in mind :)

paulhibbitts commented 5 years ago

Hi @RobLui , thanks so much for taking the time to make this PR!

Before this PR I only had a Master Branch but likely it's a good idea for me to create a Develop Branch so I can better test everything out etc - I've now created that Branch.

In your PR can I change it over to Develop without any issues? I assume once I accept your PR and do final tests I can then Merge Develop into Master.

Thanks very much, Paul

RobLui commented 5 years ago

Done :)

paulhibbitts commented 5 years ago

Awesome, thanks very much!

paulhibbitts commented 5 years ago

Hi @RobLui , I was wondering what app/editor you used for the formatting of the Twig files in this PR? I'd like to use the same formatting for my other Grav themes - thanks!

RobLui commented 5 years ago

Cool that you like it! I use phpStorm as my main editor with basic formatting options for yaml files -> indent set to: 4

If you'd like me to apply the same formatting for your other projects, I'll gladly do so :)

paulhibbitts commented 5 years ago

Thanks very much for the kind offer and info @RobLui , I'll check out phpStorm! I've been trying out various formatting filters in Atom.io as well (my usual Editor)