hibernate / hibernate-reactive

A reactive API for Hibernate ORM, supporting non-blocking database drivers and a reactive style of interaction with the database.
https://hibernate.org/reactive
Apache License 2.0
432 stars 90 forks source link

Hibernate Envers integration #394

Closed m-jayson closed 3 years ago

m-jayson commented 3 years ago

Hi,

I would like to ask if we have a way to properly integrate hibernate envers? either the hibernate envers of quarkus-hibernate-envers?

I tried using quarkus-hibernate-envers but it is giving me

Caused by: org.hibernate.envers.exception.AuditException: Unable to create revision because of non-active transaction

I tried looking at the documentation but I can't find envers or auditing or is it currently not supported?

Thanks

DavideD commented 3 years ago

Hi, Envers is currently not supported with Hibernate Reactive. We haven't looked into it yet.

m-jayson commented 3 years ago

Thanks for the fast response @DavideD .. But are you gonna look in to it in the future?

Sanne commented 3 years ago

Hi @mgonzaga1990 , we're not planning to look at it in the near future. We might revisit this in a year or more as there's many other things that need priority, so I'll close this for now.

indiealexh commented 2 years ago

I would like to bring this topic back up seeing as its over 1 year on and a feature I would love!

DavideD commented 2 years ago

I'm afraid the situation hasn't changed

SMakhrov commented 2 years ago

@Sanne , could you please clarify situation? We really need this

Sanne commented 2 years ago

@SMakhrov hi - while I think this would be really nice to have, this particular feature request is not very high in the list of strategic things we'll need to work on ourselves so it's unlikely that me or @DavideD will be implementing this, but if you or others volunteer to try it and send a pull request we'd be happy to help with guidance, suggestions and reviews.

At this point I don't know how hard it is - it's probably not too much work as Envers builds on top of the model that ORM core provides, so I expect only the cases in which Envers interfaces directly with statement execution would need to be adapted.

I would suggest make a POC ?

DyadkinMaxim commented 2 years ago

@Sanne, please could you say where I can find requirements for PR in this issue? My team is analysing the way of making audit via reactive Envers, so probably we can take part in contribution.

DavideD commented 2 years ago

Sorry, that's my fault if we haven't a contribution guideline yet. We use the same guidelines Hibernate ORM uses. You can find them on the website: https://hibernate.org/community/contribute/guidelines/

Here's a summary:

Thanks and let me know if you have more questions.

Sanne commented 2 years ago

Let's bear in mind that we're going to upgrade Hibernate Reactive to Hibernate ORM v6+ soon (it's currently still based on ORM v5), so I expect the Envers related changes would be very different.

It might be worth finishing the upgrade to 6 first and only then work on Envers integration?

gavinking commented 2 years ago

Agreed.

DyadkinMaxim commented 2 years ago

@Sanne could you say when Hibernate Reactive will be updated to v6?

DavideD commented 2 years ago

We don't have a date yet. I'm working on it

indiealexh commented 1 year ago

New Year. New need for auditing in Reactive Hibernate (◕ω◕✿)

anothergoodguy commented 1 year ago

Hi Team,

It's a great feature to have envers integrated with hibernate reactive...

Could you please share if it's in the plans?

Sanne commented 1 year ago

Hi @anothergoodguy ,

unfortunately as we're a small team I don't think we can work on this ourselves soon. But if anyone wants to give it a shot we're certainly happy to help with PR reviews and suggestions.

The upgrade to Hibernate ORM 6 is nearly done: we expect to release the version 2.0.0.Final soon, in a week or two, so it could be a good time for anyone to give this a shot.

anothergoodguy commented 1 year ago

Hi @Sanne

Thank you for the quick response... We are also a very small crowd sourced team trying to build health portals. I'll try to spread the word and see if I can get some volunteers.

vsolopov commented 1 year ago

Hi @Sanne, do you have any terms regarding that? Trying to use hibernate Envers in Quarkus 2.16.6.Final but do not see any data in audit tables :c Looks like hibernate reactive still doesn't support it.

DavideD commented 1 year ago

@vsolopov it's not integrated yet, nobody works on this issue so far.

indiealexh commented 4 months ago

Looking back into this. I don't know if I will find the time, but I am motivated to have this feature set so I will do some exploration.

anothergoodguy commented 4 months ago

hi @indiealexh any ticket to help testing and share feedback?

indiealexh commented 4 months ago

hi @indiealexh any ticket to help testing and share feedback?

Not yet, busy work week so didn't make time for it, but check back next week :)

anothergoodguy commented 2 months ago

hi @indiealexh any ticket to help testing and share feedback?

mgazim commented 3 weeks ago

Hi there! Any updates on this?

DavideD commented 3 weeks ago

I don't think anybody is working on this.

indiealexh commented 2 weeks ago

I don't think anybody is working on this.

Yeah, still trying to make time to try and contribute to this.