search

hibernating-rhinos / rhino-etl

Developer friendly ETL Library for .NET
http://hibernatingrhinos.com/open-source/rhino-etl
BSD 3-Clause "New" or "Revised" License
173 stars 54 forks source link

Support custom row key comparers #17

Closed david-durrleman closed 9 years ago

david-durrleman commented 10 years ago

The default key comparer used by QuackingDictionary, and its child class Row, can't currently be changed.

My changes allow for a custom StringComparer to be specified upon instantiation. It is then preserved over row cloning and copying. This can be useful in various scenarios:

My commit should be entirely backwards compatible and doesn't change existing behaviour. Nevertheless, for an easy performance improvement accross all users of the library, at very little cost, I would suggest changing the default value for QuackingDictionary.DefaultComparer to StringComparer.OrdinalIgnoreCase after my changes are pulled in. This should be nearly identical except in very remote corner cases, and tests on my computer have shown that it is up to 10x faster for hashing (which happens a lot in Rhino ETL applications).

nathanpalmer commented 9 years ago

Thanks for the pull @david-durrleman! This looks great and has a backward compatible API.