search

hibernating-rhinos / rhino-etl

Developer friendly ETL Library for .NET
http://hibernatingrhinos.com/open-source/rhino-etl
BSD 3-Clause "New" or "Revised" License
173 stars 53 forks source link

Make SqlBatchOperation honor UseTransaction property. #8

Closed dalenewman closed 11 years ago

dalenewman commented 11 years ago

It seems that SqlBatchOperation would ignore a UseTransaction = false setting. This change mirrors how it's handled in the bulk insert operatation.

nathanpalmer commented 11 years ago

Thanks for looking at this. I see two things that should be looked at.

  1. The code style of the BeginTransaction method doesn't match the style in the rest of the codebase (mostly just the curly braces.)
  2. We already have the same BeginTransaction as part of the AbstractCommandOperation. Since it's the exact same logic it may make sense to move it to the AbstractDatabaseOperation and share it since both of these inherit from that.
dalenewman commented 11 years ago

Ok. I'll see if I can address these issues and resubmit . Thanks

On Saturday, July 20, 2013, Nathan Palmer wrote:

Thanks for looking at this. I see two things that should be looked at.

  1. The code style of the BeginTransaction method doesn't match the style in the rest of the codebase (mostly just the curly braces.)
  2. We already have the same BeginTransaction as part of the AbstractCommandOperation. Since it's the exact same logic it may make sense to move it to the AbstractDatabaseOperation and share it since both of these inherit from that.

— Reply to this email directly or view it on GitHubhttps://github.com/hibernating-rhinos/rhino-etl/pull/8#issuecomment-21294605 .