search

hibiken / asynq

Simple, reliable, and efficient distributed task queue in Go
MIT License
10.04k stars 716 forks source link

Remove deprecated protobuf package #870

Closed aradwann closed 3 weeks ago

aradwann commented 7 months ago

removing deprecated github.com/golang/protobuf and applying go fmt closes #855

mm2175 commented 2 months ago

@hibiken Hi, Could you please review this PR and release a new version? I'm currently cleaning up dependencies in my project that uses asynq, and noticed protobuf as a transitive dependency.

pior commented 1 month ago

PRs should be narrowly scoped, as it's hard enough to agree on "one" intention/change.

IMHO, applying go fmt without adding a CI check is just noise on a PR, and not an actual improvement.

I'm posting this comment, because I agree with the protobuf changes, and I hope we can get this merged 👌

kamikazechaser commented 1 month ago

@aradwann If possible, could we only get the protobuf changes in this PR? I'll apply a gofmt before a tagged release in any case (or with a CI).

aradwann commented 1 month ago

@kamikazechaser Hi, currently I am busy with other stuff, and idk when I get back to it

kamikazechaser commented 1 month ago

Oh ok. I don't have permissions to push to forks. So I may close this and push/attribute any of your changes in a different commit.

aradwann commented 3 weeks ago

closed in favor of https://github.com/hibiken/asynq/pull/942