search

hibiken / asynq

Simple, reliable, and efficient distributed task queue in Go
MIT License
10k stars 714 forks source link

Fix memory leaks caused by time.After #914

Closed biningo closed 3 weeks ago

biningo commented 2 months ago

Fixes #913

huangc28 commented 1 month ago

Why haven't we merge this PR?

kamikazechaser commented 1 month ago

Thanks @biningo, we will migrate this library to v1.23 soon.

kamikazechaser commented 3 weeks ago

If we were to move this library to 1.23, this change wouldn't be required at all. I am not sure if this optimization is worth it (at the expense of code complexity) for what could possibly be 2 months (or even less).

cc/ @pior @l0nax

biningo commented 3 weeks ago

If we were to move this library to 1.23, this change wouldn't be required at all. I am not sure if this optimization is worth it (at the expense of code complexity) for what could possibly be 2 months (or even less).

cc/ @pior @l0nax

Upgrading to Go 1.23 is a better solution.

kamikazechaser commented 3 weeks ago

Sounds good. I'll close this for now. Thanks for highlighting this though!