search

hibiken / asynq

Simple, reliable, and efficient distributed task queue in Go
MIT License
10.03k stars 716 forks source link

Need to support redis sentinel username. #924

Closed Skwol closed 3 weeks ago

Skwol commented 4 weeks ago

Redis sentinel deploy assumes that there should be several users, one for auth in sentinel for getting proper redis instance address and the other one for actual redis auth. Need to support this.

Skwol commented 3 weeks ago

Looks like it requires golang update, I see that there is a PR exactly for update. I guess I can wait for this PR to be merged and rebuild this one after that.

kamikazechaser commented 3 weeks ago

@Skwol Merged the other PR.

Skwol commented 3 weeks ago

I've rebased with the master, so now CI should work fine

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.65%. Comparing base (c8c8adf) to head (df56e07). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
asynq.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #924 +/- ## ========================================== - Coverage 66.66% 66.65% -0.02% ========================================== Files 29 29 Lines 4308 4309 +1 ========================================== Hits 2872 2872 - Misses 1146 1147 +1 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.