Run golangci-lint in CI - Githubissues

hibiken / asynq

Simple, reliable, and efficient distributed task queue in Go

MIT License

10.03k stars 716 forks source link

Run golangci-lint in CI #927

Closed pior closed 3 weeks ago

pior commented 3 weeks ago

Context

We want to run linters in CI

Changes

Add a new Github Action workflow to run the official golangci-lint action, with the latest golangci-lint release
Fix linting errors when possible
Locally disable the failing linter on the deprecated protobuf API (since we should upgrade)

The fix for the context.CancelFunc errors has its own PR since it's a bug: https://github.com/hibiken/asynq/pull/926