hibiken / asynqmon

Web UI for Asynq task queue
MIT License
609 stars 133 forks source link

Redis URL is not working as documented #243

Open NobodysNightmare opened 2 years ago

NobodysNightmare commented 2 years ago

Hey there,

I just noticed today that parsing the REDIS_URL environment variable does not work as documented.

Environment

Expected behaviour

Asynqmon works correctly when passing an environment variable like REDIS_URL=redis://example.com. I take this from the docs linked for possible URL formats, specifically:

redis://[:password@]host[:port][/dbnumber]

I am interpreting the brackets ([]) to denote optional parts, thus expecting the port to be optional.

Actual behaviour

It is necessary to indicate the port in the URL, like so REDIS_URL=redis://example.com:6379. Using the URL from the expected behaviour causes an error, which through the browser inspector can be read as:

dial tcp: address redis.asynq.arh-staging.de: missing port in address