search

hibiken / asynqmon

Web UI for Asynq task queue
MIT License
644 stars 143 forks source link

Properly use Redis and Sentinel password #271

Open akhy opened 2 years ago

akhy commented 2 years ago

This is to follow up with changes from https://github.com/hibiken/asynq/pull/537 from @sillydong

Updated the tests to show the correct expected behavior from above PR. But since the PR has not released yet, I added a temporary workaround in main.go to make the tests pass.

Will remove the workaround and update deps once https://github.com/hibiken/asynq/pull/537 has tag release. @hibiken You might not want to merge this PR until then.

akhy commented 2 years ago

Updated the deps and removed the workaround. Will still wait a new release tag of hibiken/asynq

sillydong commented 2 years ago

I planned to create PR here, just forgot to do so. Thanks for this update.

abawchen commented 11 months ago

@akhy : Thanks for the effort! :+1: @hibiken : Any plan to merge this one? Or do you need someone to fix the CI? I can help if necessary. I really need it, thanks.

akhy commented 10 months ago