search

hibiken / stories

Medium clone built with Ruby on Rails
https://my-medium-clone.herokuapp.com/
MIT License
806 stars 270 forks source link

Using browser's back button #35

Open yigitbacakoglu opened 7 years ago

yigitbacakoglu commented 7 years ago

If you click 'Back Button' on browser or (swipe your magic mouse to left) after you click any link that changes the view (eg. Click on a tag), latest view slides down and the container remains empty.

hibiken commented 7 years ago

@yigitbacakoglu Thanks for the bug report. If anyone can fix this issue, please submit a PR 👍

rawdreeg commented 7 years ago

will work on this ...

rawdreeg commented 7 years ago

@kenny-hibino issue is caused by Turbolinks not playing nice with JS. Removing turbolinks should fix this

R

garrettcadams commented 7 years ago

@rawdreeg fork it and fix it i will give you a vps to work in i love this project but i dont know anything about ruby i want to use it as and open source project team blog

AjayBarot commented 7 years ago

@rawdreeg @kenny-hibino : This issue has been already reported to react-rails. Please see this github issue. and changed has been pushed into master branch of react-rails. So by updating react-rails gem this issue will resolved. And I prefer not to remove turbolinks.

rawdreeg commented 7 years ago

gread news :D

On 13 March 2017 at 14:17, AjayBarot notifications@github.com wrote:

@rawdreeg https://github.com/rawdreeg @kenny-hibino https://github.com/kenny-hibino : This issue has been already reported to react-rails. Please see this github issue https://github.com/reactjs/react-rails/issues/159. and changed has been pushed into master branch of react-rails. So by updating react-rails gem this issue will resolved. And I prefer not to remove turbolinks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kenny-hibino/stories/issues/35#issuecomment-286091308, or mute the thread https://github.com/notifications/unsubscribe-auth/AEA5c9kCuQdxDNx_6g5e-VDq--xzuREPks5rlTPugaJpZM4KpTCg .

hibiken commented 7 years ago

@AjayBarot I merged your pull request! I'm still seeing the bug with the back navigation. Do you have bandwidth to investigate further?

AjayBarot commented 7 years ago

@kenny-hibino : I suspect progress bar issue and some part of UI is not showing after back button. Issue is with turbolinks caching. Following are the possible solutions.

  1. Update the turbolinks to newer version. right now we are using turbolinks 2.5.3
  2. On particular page disable turbolinks.
  3. Removed turbolinks gem and js from the project.

I am working on solution 1 and I will submit PR tomorrow.

Please share your suggestion and concern.

dripisforever commented 7 years ago

@AjayBarot is there any news?

AjayBarot commented 7 years ago

@strivemag : I created one pull request regarding this issue. and pull request still need to reviewed. https://github.com/kenny-hibino/stories/pull/45