add highlight-self - Githubissues

hibiyasleep / ikegami

Horizontal FFXIV Miniparse Overlay

Other

50 stars 16 forks source link

add highlight-self #17

Closed mochimisu closed 5 years ago

mochimisu commented 5 years ago

i like your overlay, and the only issue i was having was being able to find myself quickly, at a glance.

i made a small mod to highlight yourself

mochimisu commented 5 years ago

i've also made a second commit to add a group-by-4, as my friend requested it when i showed him your overlay, however i had to fix some z-indexing issues with the c-details pane so that they overlay correctly. the changes are a bit deep so no worries if you don't want to merge it:

hibiyasleep commented 5 years ago

(please note, I'm not familiar with english writing, words may seems rude but that's definitely not intended.)

Those -ㅁ- only indicates that's yourself? this style of highlighting seems nice, but it would cause distraction by two presentive lines (DPS/Crit) that already exists. (also check what happens with Element 2: None)
Group by-4 also looks awesome, but what happens if user jumps into 24-player duty, FATE or Eureka? How about make this option configurable (Group by n), or we should limit player region's total height.

mochimisu commented 5 years ago

no worries, thanks for taking a look.

i cleaned it up a bit, fixed the element 2: none, and changed the lines to gradients. group by 4 is now 2 rows

(if you want to change the style, feel free to - just making an example :) )