hibiyasleep / ikegami

Horizontal FFXIV Miniparse Overlay
Other
50 stars 16 forks source link

Adding i18n system to ikegami and chinese translation #35

Open oott123 opened 3 years ago

oott123 commented 3 years ago

Hi hibiyasleep!

Sorry for this huge PR.

In this PR I have:

There are also some small fixes that I may forgot to mention about, sorry for that again.

This PR is ready for review. If you can review and merge my PR, I'll very happy to answer any questions.

Thank you!

hibiyasleep commented 2 years ago

in first of all, sorry, lack of i18n was intentional, since I had suffered on kagerou, as I can't write strings in all possible languages, this caused imperfection (or glitchy) on the user interface. I speaks ko_KR, en_US, ja_JP, and very little of zh_TW (traditional) as I can write little 漢字, but there were zh_CN, fr_FR, de_DE remained. they were almost not maintained for long time still.

tldr: code has no problem, i18n is hard, since I can't speak all of them. I saw this PR just now (very sorry!!), so I need a time to think it'll be okay or not.

oott123 commented 2 years ago

IMO it's okay to left untranslated strings in English, and left them to be translated by others, that's how community works!