search

hibiyasleep / kagerou

ACT-FF14 OverlayPlugin Skin - Modern, easily configurable, always up-to-date.
Other
336 stars 96 forks source link

Skill names too long to fit under MaxHeal column #114

Open NolanSeryn opened 5 years ago

NolanSeryn commented 5 years ago

While the "MaxHit" column for DPS skills works very well at showing a shortened 'skill alias', like Midare/Guren/Ref. Arrow, and so on, I've noticed that the same alias shortening doesn't apply to heal skills, causing the healing amounts to get "cut off", as it were.

For example, a Samurai would see, under the MaxHit column, "Midare: 25,000" or so, while a Scholar using Indomitability would see "Indomitability: ", with the healing amount cut off and not displayed. The same things happens with Stellar Explosion, Thrill Of Battle, Excogitation, Essential Dignity and Lady of Crowns (as far as I can tell, I'm unsure if more skills behave this way).

I'm trying to experiment with using the Tank and Heal tabs a bit more, to see how I'm doing for personal research, so I know this is a minor issue - but still, is there a way to set healing "Skill Aliases"? It seems like there aren't any aliases in use for healing skills at all, so they just have their healing values cut off from the column. I even went looking through some of the source code files and found the "Alias" list in en.json, but that seems to only affect and apply to damage skills.

P.S. for anyone else : I've gotten around this issue temporarily by using "MaxHeal (skill name only)" and "MaxHeal (w/o skill name)" next to each other, but even that seems to have some text-space issues. I've added a few images to help show the problem.

Thanks in advance! image image

hibiyasleep commented 5 years ago

Kagerou already supports skill name aliasing, however there's too many long named skills, not of all skills are covered. ;( If you can, please help writing more aliases.

NolanSeryn commented 5 years ago

Kagerou already supports skill name aliasing, however there's too many long named skills, not of all skills are covered. ;( If you can, please help writing more aliases.

I tried to, actually! I tried to shorten "Thrill of Battle" to just "Thrill", but the aliases didn't seem to persist through to the overlay. I may not fully understand how the overlay URL and the github files work, to be quite honest. However, I'd love to help add in a few aliases if I knew how! Would it just require adding to, and then updating, en.json?

hibiyasleep commented 5 years ago

yep, just open a PR if possible.