hicetnunc2000 / hicetnunc

hicetnunc UI/UX
http://hicetnunc.xyz
800 stars 281 forks source link

Meta tags for sharing #159

Open seb776 opened 3 years ago

seb776 commented 3 years ago

Hi there !

I noticed the site doesn't generate any preview when shared to social (even discord), after a bit of research it appears that this requires some meta tags to be added to the pages, that IMO would be a really nice improvement.

crzypatchwork commented 3 years ago

I believe this can be tackled with dynamic open graphs but I resetted all open graphs configurations

Quasimondo commented 3 years ago

Just would like to resurface this issue. Maybe someone who knows can point out where to start in the codebase to improve this?

skenaja commented 3 years ago

I think there's an open pull request to help with this https://github.com/hicetnunc2000/hicetnunc/pull/300

Hornebom commented 3 years ago

@skenaja the pr only provides a general og share image. I can extend the code to use a thumbnail for objkt-display. Or open another pr with such a feature. Haven't looked into thumbnails. Are they already available?

Quasimondo commented 3 years ago

I think thumbnails would require some rendering engine on the backend that can be quite complex for elements that are not images. I do have some python code for my own purposes that creates them locally for most media, but in particular for videos, SVGs and GLB files this can be quite memory and computationally intensive so I am not sure what the best approach would be for this.

Ideally a thumbnail would be generated at minting time or as an additional option that can be added to the NFT and I think there is already a reserved attribute for it in the NFT metadata. Just not sure if this coulld be implemented and a way that is backward-compatible with the >15000 OBJKTs minted so far.

kylegrover commented 3 years ago

Ran into this today, all we need is <meta property="og:image" content="https://cloudflare-ipfs.com/ipfs/IPFS_HASH_HERE"> where the hash is their image or thumbnail. In particular, interactive/html OBJKTs already have an og:image internally that could just be fetched and set as the hicetnunc webpage's og:image. For example https://www.hicetnunc.xyz/objkt/39107 should be able to set its og:image to its pre-generated thumbnail at https://cloudflare-ipfs.com/ipfs/QmXyE8BuiPYTx77DcVQUoj9gBqwLJa8hQfusBMF8MFzJSK

enginarer commented 3 years ago

This is what you're looking for: https://ogp.me/

This is the Open Graph protocol that is grabbing some features like images, videos, title & description for the link previews. Hicetnunc already has this in the area, but as kyle mentioned, it's static and directing only to the title: "hic et nunc", desc: "decentralized digital assets" and og:image: [hen logo].

This should be dynamic and direct to the OBJKT title, desc & image/video, etc. The only other thing that needs attention is the OBJKT type; if it's an image or video, because they have different tags respectively...