search

hicetnunc2000 / hicetnunc

hicetnunc UI/UX
http://hicetnunc.xyz
800 stars 281 forks source link

Cancel Swap errors due to old contract #992

Closed Asong64 closed 3 years ago

Asong64 commented 3 years ago

Unable to cancel swap from HEN using Temple and Kukai wallets. Error codes for both. Temple wallet - Transaction Likely to Fail Kukai wallet - Simulation error: A FAILWITH instruction was reached Owned editions show up in Hicdex, but not in HEN collectors tab. (only purchased editions show up in HEN)

To Reproduce Steps to reproduce the behavior:

  1. Go to HEN
  2. Click on V1 Swaps
  3. Click on Cancel Swap for an item
  4. Wallet brings up window
  5. Click confirm
  6. Error shows: The transaction is invalid and the node did not accept it.

Expected behavior Wallet should bring up window allowing for adjustment of storage value. (without "transaction likely to fail" messaging) Click confirm, then wallet should continue with transaction.

Screen Shot 2021-07-09 at 7 29 31 PM

Desktop (please complete the following information):

Additional context I believe that this may be due to something with the old contract. Someone on the discord sent me this screenshot: unknown

tenineight commented 3 years ago

I have two separate accounts and only one of them shows the same issue. In case you need to deep dive: tz1dqCHsxC2npF9iu8MBrEn6rwLPMUbxNjeg <-- this is where the OBJKTs seem to be stuck on v1

skenaja commented 3 years ago

It looks like the batch_cancel function is calling the v2 cancel_swap method, and which will fail as the swap ids don't exist in the v2 contract.

image

Temple popup operation has wrong destination: [ { "destination": "KT1HbQepzV1nVGg8QVznG7z4RcHseD5kwqBn", "kind": "transaction", "amount": 0, "storageLimit": "310", "parameters": { "entrypoint": "cancel_swap", "value": { "int": "219019" } } } ]

V1 swaps look OK for cancelling:

skenaja commented 3 years ago

Here's the workaround pending a fix:

  1. https://old.objkt.bid/profile
  2. sign in with your wallet
  3. clear the active v1 swaps with this button

image

tenineight commented 3 years ago

@skenaja Thank you that worked!

Asong64 commented 3 years ago

Thank you, but I'm still getting the same errors as before. (please see attached image) Screen Shot 2021-07-10 at 8 55 40 AM

skenaja commented 3 years ago

This should be fixed by 10f0c5e71f3444f9303859f079c976f217bda850.

The new fix might cause backtracks as it doesn't default the storage amount, so increase storage to 310 if you use temple

skenaja commented 3 years ago

@Asong64 - that's a bug with objkt.bid, you can contact them for support on their discord https://discord.gg/5yDdS5xY

The cancel bug should now be fixed on hicetnunc if you want to try again

Asong64 commented 3 years ago

Thank you! I have successfully cancelled and relisted my editions! I appreciate all your hard work over there. Take care.

On Sat, Jul 10, 2021 at 10:29 AM skenaja @.***> wrote:

@Asong64 https://github.com/Asong64 - that's a bug with objkt.bid, you can contact them for support on their discord https://discord.gg/5yDdS5xY

The cancel bug should now be fixed on hicetnunc if you want to try again

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hicetnunc2000/hicetnunc/issues/992#issuecomment-877673278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AULWG62BPPQROJLUCXF5FRDTXB7PZANCNFSM5ADX4WEA .