search

hicetnunc2000 / objkt-swap

Hic et Nunc smart contracts. FA2 multiassets: hDAO, OBJKTs, Marketplace, SUBJKTs and Unregistry.
79 stars 48 forks source link

Increases bus accident factor #5

Closed jagracar closed 3 years ago

jagracar commented 3 years ago

Still a prototype. I created this pull request mostly for discussion.

crzypatchwork commented 3 years ago

I don't think we're changing the smart contract marketplace. I suggest that we update the manager with a new contract for such distribution.

jagracar commented 3 years ago

I don't think we're changing the smart contract marketplace. I suggest that we update the manager with a new contract for such distribution.

Could you clarify it a bit? With the current marketplace contract i don't see a way to change the manager and move the hicetnunc funds in case of a "bus accident". Only the current manager can change the manager and the keys of the fees account are only known by the manager.

However, i understand that this is not a top priority and that releasing v2 is now the most urgent thing. Maybe for v3 in some months?

I just wanted to write a prototype to described more clearly what I had in mind :)

crzypatchwork commented 3 years ago

Yes, I suggest that we update the manager for the smart contract marketplace. This smart contract is able still to change manager for another contract or account still, but it would be able to split the fees as a manager to other addresses. I would suggest for us to try it at first distributing to the tibum residency and possibly a dev wallet. Splitting contracts themselves could be used in this case as well, instead of addressing such funds to a wallet. Other token economics are possible as well, but this can an first step towards distributing some demands, but still the bus factor aspect remains a bit. Looking forward to share insights on such prototypes also.

jagracar commented 3 years ago

Yes, I suggest that we update the manager for the smart contract marketplace. This smart contract is able still to change manager for another contract or account still, but it would be able to split the fees as a manager to other addresses. I would suggest for us to try it at first distributing to the tibum residency and possibly a dev wallet. Splitting contracts themselves could be used in this case as well, instead of addressing such funds to a wallet. Other token economics are possible as well, but this can an first step towards distributing some demands, but still the bus factor aspect remains a bit. Looking forward to share insights on such prototypes also.

Ok, I get it now. So the manager will be a KT address and the fees will go to that address. The contract will then have different methods to transfer the funds, update the manager of that address and maybe also some methods to improve the bus factor. Yes, a much better solution!

0x00000010 commented 3 years ago

so the manager becomes a contract with rules that the actual authorised humans on the other end can interact with, or is it envisioned to be completely automatic?

jagracar commented 3 years ago

I just know what crzy wrote in the other PR.

The manager of the marketplace will be a contract. The fees will go to that contract and one will be able to update the manger of that contract, distribute the fees, improve the bus factor, etc.

Good thing is that we can create a new contract and don't need to update the marketplace contract. We just need to pass the address to the new contract with the update_manager entrypoint. That will avoid the need to cancel all swaps and swap again.

0x00000010 commented 3 years ago

Oh sweet! So being able to swap out the management contract means we can now create this new Management contract incorporating these proposed changes?

-------- Original Message -------- On Jul 6, 2021, 7:29 PM, Javier Graciá Carpio wrote:

I just know what crzy wrote in the other PR.

The manager of the marketplace will be a contract. The fees will go to that contract and one will be able to update the manger of that contract, distribute the fees, improve the bus factor, etc.

Good thing is that we can create a new contract and don't need to update the marketplace contract. We just need to pass the address to the new contract with the update_manager entrypoint

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jagracar commented 3 years ago

Yes, that's what I understood :)

jagracar commented 3 years ago

@crzypatchwork do you have already a prototype of that Manager contract? I could write a quick and dirty one to start the discussion?