hich9n / cumulusrdf

Automatically exported from code.google.com/p/cumulusrdf
0 stars 0 forks source link

Remove dependencies to NxParser? and Yars #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Remove dependencies to NxParser? and Yars, only use Sesame 
model/parsers/writers.

Original issue reported on code.google.com by andreas.josef.wagner on 22 Nov 2013 at 12:18

GoogleCodeExporter commented 9 years ago
Work has started. Open issues:

* remove package webapp.formater and replace with RIO [1] code. The only "own" 
formatter we have is the HTML formatter. This class rewritten as an impl. of 
RDFWriter in Sesame.  Then, we could hook it in Sesame, so that we have 
something like:

RDFFormat html_writer = Rio.getWriterFormatForMIMEType("text/html");

* check/update JUnit-tests
* and there are still some NxParsers used in: NodeTypeSerializer, LoadServlet, 
Util class //but this should be only minor changes

@Andrea: Feel free to add/change/remove above TODOs ;)

Kind regards
Andreas

Original comment by andreas.josef.wagner on 26 Jan 2014 at 12:23

GoogleCodeExporter commented 9 years ago
Hi, 
are NodeTypeSerializer and DoubleTypeSerializer used somewhere? Because the 
factory method in Util (guessSerializer) never has a chance to reach the create 
statement for both of them. SerializerTypeInferer from hector API always 
returns something, never null so the check if (ser == null) always returns 
false. 

In addition DoubleTypeSerializer is associated with Double.class and 
double.class but the default Hector serializer already does.

Can we remove those two classes?

Original comment by torro...@casalini.it on 27 Jan 2014 at 8:13

GoogleCodeExporter commented 9 years ago
Sorry, that was my comment with a wrong account.

Original comment by a.gazzarini@gmail.com on 27 Jan 2014 at 8:29

GoogleCodeExporter commented 9 years ago
Hi Andrea, you are right. Both of them are no longer needed - I just checked. 

Thanks :)
Andreas

Original comment by andreas.josef.wagner on 27 Jan 2014 at 10:56

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r801.

Original comment by a.gazzarini@gmail.com on 29 Jan 2014 at 3:11

GoogleCodeExporter commented 9 years ago
Short description of changes:

1) pom.xml
The nx dependency has been removed but there was a transitive dependency that 
now is directly imported: commons-cli:commons-cli:1.2

2) NodeTypeSerializer has been removed 
3) Utils.guessSerializer is a (at moment unuseful, I believe) wrapper around 
SerializerTypeInferer
4) DoubleTypeSerializer hasn't been removed because needed somewhere.
5) Environment.RDFFileExtensions has been removed. RDFFormat is used instead
6) Environment.RDFSerializationFormats has been removed. RDFFormat is used 
instead
7) Minor modifications on Dump and Load from cli package for replacing the 
format (from String to Sesame RDFFormat)
8) AbstractCassadraRdfHector: minor modifications for replacing the format 
(from String to Sesame RDFFormat)
9) CumulusRDFIterator: removed an unused nx references
10) CumulusRDFSailConnection: removed nx references
11) CumulusRDFValueFactory: removed nx references
12) Util: removed nx references + introduced some compose methods in order to 
avoid redundancy. There are some TODO for logging that will be fixed in #25
13) LoadServlet: removed nx references
14) TriplePatternServlet: removed nx references
15) HTMLFormat: in the print method there's a temporary CharArrayWriter that 
encodes nt triples (otherwise Tidy was not happy with the result html)
16)  NTriplesFormat: added startRDF and endRDF calls to RDFWriter that caused 
test failures ("Document writing has not been started yet") 
17) SimpleRDFXMLFormat: added startRDF and endRDF calls to RDFWriter that 
caused test failures ("Document writing has not been started yet")
18) test package: added some minor modifications for adapting test cases. 

Original comment by a.gazzarini@gmail.com on 29 Jan 2014 at 3:12