search

hichamjanati / groupmne

Multi-subject MEG and EEG source localization with MNE
MIT License
9 stars 3 forks source link

[WIP] Fix bug with oct6 and fix dependencies #23

Closed agramfort closed 4 years ago

agramfort commented 4 years ago

this tiny change leads to an index error running this code. Can you have a look @hichamjanati ? thanks

hichamjanati commented 4 years ago

This has nothing to do with the example, something changed in the dependencies right ?

hichamjanati commented 4 years ago

in travis, mayavi's installation fails ...

hichamjanati commented 4 years ago

This should fix the bug; but apparently there is still a plotting problem with the doc ...

hichamjanati commented 4 years ago

I thought i pushed .. its done

Le mer. 27 mai 2020 à 17:43, Alexandre Gramfort notifications@github.com a écrit :

@agramfort commented on this pull request.

In .travis.yml https://github.com/hichamjanati/groupmne/pull/23#discussion_r431242884:

cache: apt: true

  • pip: true

  • pip: true

why did you resolve it's not done

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hichamjanati/groupmne/pull/23#discussion_r431242884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECC63A5EM5SQ3JR2O7Z3PLRTUYITANCNFSM4NJBY43Q .

agramfort commented 4 years ago

Just pushed to try to fix circle

codecov[bot] commented 4 years ago

Codecov Report

Merging #23 into master will increase coverage by 0.57%. The diff coverage is 96.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   77.08%   77.65%   +0.57%     
==========================================
  Files          10       10              
  Lines         707      743      +36     
  Branches      115      123       +8     
==========================================
+ Hits          545      577      +32     
- Misses        143      146       +3     
- Partials       19       20       +1
Impacted Files Coverage Δ
groupmne/utils.py 66.44% <42.85%> (-1.80%) :arrow_down:
groupmne/group_model.py 98.24% <100.00%> (+0.13%) :arrow_up:
groupmne/tests/conftest.py 100.00% <100.00%> (ø)
groupmne/tests/test_group.py 100.00% <100.00%> (ø)
groupmne/tests/test_inverse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ac766a...0f0b4de. Read the comment docs.

agramfort commented 4 years ago

great job @hichamjanati !