search

hichamjanati / groupmne

Multi-subject MEG and EEG source localization with MNE
MIT License
9 stars 3 forks source link

some edits after a first review #4

Closed agramfort closed 5 years ago

agramfort commented 5 years ago

cc @hichamjanati

codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will decrease coverage by 0.19%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
- Coverage   91.15%   90.96%   -0.2%     
=========================================
  Files           9        9             
  Lines         475      476      +1     
  Branches       71       71             
=========================================
  Hits          433      433             
- Misses         25       26      +1     
  Partials       17       17
Impacted Files Coverage Δ
groupmne/inverse.py 100% <ø> (ø) :arrow_up:
groupmne/tests/test_group.py 100% <100%> (ø) :arrow_up:
groupmne/group_model.py 90.35% <50%> (-0.8%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2b0743...b127212. Read the comment docs.

hichamjanati commented 5 years ago

Thanks for this review @agramfort. Shall we merge ?

agramfort commented 5 years ago

yes please merge and fix the remaining in a follow up PR. thx